Below is a differential between the unpatched vulnerable code and the patched update, for reference.
--- a/acf-frontend-form-element/acf-frontend.php
+++ b/acf-frontend-form-element/acf-frontend.php
@@ -3,7 +3,7 @@
* Plugin Name: Frontend Admin
* Plugin URI: https://www.dynamiapps.com/frontend-admin/
* Description: This awesome plugin allows you to easily display admin forms to the frontend of your site so your clients can easily edit content on their own from the frontend.
- * Version: 3.29.5
+ * Version: 3.29.8
* Author: Shabti Kaplan
* Author URI: https://www.dynamiapps.com/
* Text Domain: frontend-admin
--- a/acf-frontend-form-element/assets/build/admin-form/index.asset.php
+++ b/acf-frontend-form-element/assets/build/admin-form/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-editor', 'wp-i18n'), 'version' => '6c99b59cbc083ea3dc47');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-editor', 'wp-i18n'), 'version' => '6c99b59cbc083ea3dc47');
--- a/acf-frontend-form-element/assets/build/block-settings/index.asset.php
+++ b/acf-frontend-form-element/assets/build/block-settings/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'react-dom', 'wp-block-editor', 'wp-components', 'wp-compose', 'wp-element', 'wp-hooks'), 'version' => '1256001e9c6a25fcbc0b');
+<?php return array('dependencies' => array('react', 'react-dom', 'wp-block-editor', 'wp-components', 'wp-compose', 'wp-element', 'wp-hooks'), 'version' => '1256001e9c6a25fcbc0b');
--- a/acf-frontend-form-element/assets/build/checkbox/index.asset.php
+++ b/acf-frontend-form-element/assets/build/checkbox/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => '514989f46a2c529a0ce5');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => '514989f46a2c529a0ce5');
--- a/acf-frontend-form-element/assets/build/color/index.asset.php
+++ b/acf-frontend-form-element/assets/build/color/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => 'aed658a96b50270f0e2c');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => 'aed658a96b50270f0e2c');
--- a/acf-frontend-form-element/assets/build/date/index.asset.php
+++ b/acf-frontend-form-element/assets/build/date/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '64ed976483b2fd8cfbd8');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '64ed976483b2fd8cfbd8');
--- a/acf-frontend-form-element/assets/build/datetime/index.asset.php
+++ b/acf-frontend-form-element/assets/build/datetime/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '93d1fbdaaf3f5923ef00');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '93d1fbdaaf3f5923ef00');
--- a/acf-frontend-form-element/assets/build/email/index.asset.php
+++ b/acf-frontend-form-element/assets/build/email/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '7800530d0a03545694fc');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '7800530d0a03545694fc');
--- a/acf-frontend-form-element/assets/build/featured-image/index.asset.php
+++ b/acf-frontend-form-element/assets/build/featured-image/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n', 'wp-primitives'), 'version' => '3b496cee84b35ee1c7d4');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n', 'wp-primitives'), 'version' => '3b496cee84b35ee1c7d4');
--- a/acf-frontend-form-element/assets/build/field/index.asset.php
+++ b/acf-frontend-form-element/assets/build/field/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-element', 'wp-i18n'), 'version' => 'ad053bbd75f8fc68cee5');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-element', 'wp-i18n'), 'version' => 'ad053bbd75f8fc68cee5');
--- a/acf-frontend-form-element/assets/build/fields-select/index.asset.php
+++ b/acf-frontend-form-element/assets/build/fields-select/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'react-dom', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n', 'wp-server-side-render'), 'version' => '570524239ba727f40663');
+<?php return array('dependencies' => array('react', 'react-dom', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n', 'wp-server-side-render'), 'version' => '570524239ba727f40663');
--- a/acf-frontend-form-element/assets/build/number/index.asset.php
+++ b/acf-frontend-form-element/assets/build/number/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '1bf7601d6561abf63752');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '1bf7601d6561abf63752');
--- a/acf-frontend-form-element/assets/build/password/index.asset.php
+++ b/acf-frontend-form-element/assets/build/password/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '55c8d4ad3b68460071ee');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '55c8d4ad3b68460071ee');
--- a/acf-frontend-form-element/assets/build/payment-form/index.asset.php
+++ b/acf-frontend-form-element/assets/build/payment-form/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'react-dom', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => 'a429a12050e0d1e41020');
+<?php return array('dependencies' => array('react', 'react-dom', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => 'a429a12050e0d1e41020');
--- a/acf-frontend-form-element/assets/build/post-content/index.asset.php
+++ b/acf-frontend-form-element/assets/build/post-content/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => 'fb70e03e5e8ea549b9d2');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => 'fb70e03e5e8ea549b9d2');
--- a/acf-frontend-form-element/assets/build/post-excerpt/index.asset.php
+++ b/acf-frontend-form-element/assets/build/post-excerpt/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '2f9dbbf9d0088086de16');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '2f9dbbf9d0088086de16');
--- a/acf-frontend-form-element/assets/build/post-title/index.asset.php
+++ b/acf-frontend-form-element/assets/build/post-title/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => 'b37019c4264ae26c36f6');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => 'b37019c4264ae26c36f6');
--- a/acf-frontend-form-element/assets/build/range/index.asset.php
+++ b/acf-frontend-form-element/assets/build/range/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '188a1b110340d7b580b5');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '188a1b110340d7b580b5');
--- a/acf-frontend-form-element/assets/build/repeater/index.asset.php
+++ b/acf-frontend-form-element/assets/build/repeater/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '2d1829b16b55cabb3aed');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '2d1829b16b55cabb3aed');
--- a/acf-frontend-form-element/assets/build/select/index.asset.php
+++ b/acf-frontend-form-element/assets/build/select/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => '2bea902214c4fa0a50df');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => '2bea902214c4fa0a50df');
--- a/acf-frontend-form-element/assets/build/step/index.asset.php
+++ b/acf-frontend-form-element/assets/build/step/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-i18n'), 'version' => '06afd7ec4c8191345cfd');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-i18n'), 'version' => '06afd7ec4c8191345cfd');
--- a/acf-frontend-form-element/assets/build/steps/index.asset.php
+++ b/acf-frontend-form-element/assets/build/steps/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-i18n'), 'version' => 'e55dfe64a273d5da46a8');
+<?php return array('dependencies' => array('wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-i18n'), 'version' => 'e55dfe64a273d5da46a8');
--- a/acf-frontend-form-element/assets/build/submissions/index.asset.php
+++ b/acf-frontend-form-element/assets/build/submissions/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-editor', 'wp-i18n'), 'version' => 'b154216582580670bbbd');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-editor', 'wp-i18n'), 'version' => 'b154216582580670bbbd');
--- a/acf-frontend-form-element/assets/build/submit-button/index.asset.php
+++ b/acf-frontend-form-element/assets/build/submit-button/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '54f2222d622030115491');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '54f2222d622030115491');
--- a/acf-frontend-form-element/assets/build/text-editor/index.asset.php
+++ b/acf-frontend-form-element/assets/build/text-editor/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => '996f079043b7846f5770');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-i18n'), 'version' => '996f079043b7846f5770');
--- a/acf-frontend-form-element/assets/build/text/index.asset.php
+++ b/acf-frontend-form-element/assets/build/text/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '50f6a5de0ed1e4328c9a');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '50f6a5de0ed1e4328c9a');
--- a/acf-frontend-form-element/assets/build/textarea/index.asset.php
+++ b/acf-frontend-form-element/assets/build/textarea/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '03233542c59fb1ffb187');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '03233542c59fb1ffb187');
--- a/acf-frontend-form-element/assets/build/time/index.asset.php
+++ b/acf-frontend-form-element/assets/build/time/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '4379602ee7470fcb7ff8');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '4379602ee7470fcb7ff8');
--- a/acf-frontend-form-element/assets/build/url/index.asset.php
+++ b/acf-frontend-form-element/assets/build/url/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '9309064a392cb8525304');
+<?php return array('dependencies' => array('react', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-i18n'), 'version' => '9309064a392cb8525304');
--- a/acf-frontend-form-element/main/admin/admin-pages/forms/sections/permissions.php
+++ b/acf-frontend-form-element/main/admin/admin-pages/forms/sections/permissions.php
@@ -229,6 +229,8 @@
'choices' => array(
'edit_posts' => __( 'Edit Other's Posts', 'frontend-admin' ),
'edit_users' => __( 'Edit Other Users', 'frontend-admin' ),
+ 'edit_terms' => __( 'Edit Terms', 'frontend-admin' ),
+ 'delete_terms' => __( 'Delete Terms', 'frontend-admin' ),
),
'conditional_logic' => array(
array(
--- a/acf-frontend-form-element/main/elementor/classes/permissions.php
+++ b/acf-frontend-form-element/main/elementor/classes/permissions.php
@@ -194,8 +194,10 @@
'type' => Controls_Manager::SELECT2,
'multiple' => true,
'options' => array(
- 'edit_posts' => __( 'Edit Other's Posts', 'frontend-admin' ),
- 'edit_users' => __( 'Edit Users', 'frontend-admin' ),
+ 'edit_posts' => __( 'Edit Other's Posts', 'frontend-admin' ),
+ 'edit_users' => __( 'Edit Users', 'frontend-admin' ),
+ 'edit_terms' => __( 'Edit Terms', 'frontend-admin' ),
+ 'delete_terms' => __( 'Delete Terms', 'frontend-admin' ),
),
'description' => __( 'Allow special permssions. For example, allow authors to edit other user's posts or other users', 'frontend-admin' ),
)
--- a/acf-frontend-form-element/main/frontend/fields/general/class-delete-object.php
+++ b/acf-frontend-form-element/main/frontend/fields/general/class-delete-object.php
@@ -142,7 +142,8 @@
$term_id = intval( $objects['term'] );
if( ! $term_id ) wp_send_json_error( __( 'No Term ID Found', 'frontend-admin' ) );
- if ( ! current_user_can( 'delete_term', $term_id ) && ! $allowed_by_settings ) {
+ $term_special_permissions = $field['special_permissions'] ?? array();
+ if ( ! current_user_can( 'delete_term', $term_id ) && ! in_array( 'delete_terms', $term_special_permissions ) ) {
wp_send_json_error( __( 'You do have have permission to delete this term', 'frontend-admin' ) );
}
$deleted = wp_delete_term( $term_id, sanitize_title( $_POST['_acf_taxonomy_type'] ) );
--- a/acf-frontend-form-element/main/frontend/fields/general/class-field-base.php
+++ b/acf-frontend-form-element/main/frontend/fields/general/class-field-base.php
@@ -23,6 +23,12 @@
'required' => true,
);
+ // Tracks whether the global remaining-characters hook has been registered (only needs to happen once).
+ private static $remaining_characters_hooked = false;
+
+ // Tracks whether the ACF native field type settings hooks have been registered.
+ private static $acf_char_counter_hooked = false;
+
/*
* __construct
*
@@ -41,7 +47,25 @@
$this->initialize();
-
+ if ( ! self::$remaining_characters_hooked ) {
+ self::$remaining_characters_hooked = true;
+ add_filter( 'acf/prepare_field', array( __CLASS__, 'add_remaining_characters_attrs' ), 20 );
+ }
+
+ if ( ! self::$acf_char_counter_hooked ) {
+ self::$acf_char_counter_hooked = true;
+ // ACF native text/textarea already have maxlength — just append the toggle.
+ add_action( 'acf/render_field_settings/type=text', array( __CLASS__, 'inject_show_remaining_setting' ), 20 );
+ add_action( 'acf/render_field_settings/type=textarea', array( __CLASS__, 'inject_show_remaining_setting' ), 20 );
+ // ACF native email/url have no maxlength — add both settings.
+ add_action( 'acf/render_field_settings/type=email', array( __CLASS__, 'inject_char_limit_and_remaining' ), 20 );
+ add_action( 'acf/render_field_settings/type=url', array( __CLASS__, 'inject_char_limit_and_remaining' ), 20 );
+ // Server-side validation for types that don't natively enforce maxlength.
+ add_filter( 'acf/validate_value/type=email', array( __CLASS__, 'validate_char_limit' ), 20, 4 );
+ add_filter( 'acf/validate_value/type=url', array( __CLASS__, 'validate_char_limit' ), 20, 4 );
+ }
+
+
if( $this->public && '' !== $this->name ) acf_register_field_type( $this );
@@ -380,7 +404,159 @@
// return
return $field;
}
-
+
+ /**
+ * Adds the "remaining characters" wrapper data attributes to any field (regardless of
+ * type) that has a character limit and has opted in to showing the remaining count.
+ * Hooked once into the generic (non type-specific) "acf/prepare_field" filter so it
+ * applies to every text-based field type, not just textarea.
+ *
+ * @param array $field
+ * @return array
+ */
+ public static function add_remaining_characters_attrs( $field ) {
+ if ( empty( $field['maxlength'] ) || empty( $field['show_remaining_characters'] ) ) {
+ return $field;
+ }
+
+ $field['wrapper']['data-char-remaining'] = 1;
+ $field['wrapper']['data-remaining-text'] = $field['remaining_characters_text'] ?? '';
+ $field['wrapper']['data-maxlength'] = $field['maxlength'];
+
+ return $field;
+ }
+
+ /**
+ * Renders the "Show Remaining Characters" and "Remaining Characters Text" field settings.
+ * Shared by any field type that supports a character limit (text, text_editor, etc).
+ * Requires the field to also expose a "maxlength" setting.
+ *
+ * @param array $field
+ * @return void
+ */
+ function remaining_characters_setting( $field ) {
+ acf_render_field_setting(
+ $field,
+ array(
+ 'label' => __( 'Show Remaining Characters', 'frontend-admin' ),
+ 'instructions' => __( 'Display the number of characters remaining based on the maxlength setting', 'frontend-admin' ),
+ 'type' => 'true_false',
+ 'name' => 'show_remaining_characters',
+ 'ui' => 1,
+ 'conditions' => array(
+ array(
+ 'field' => 'maxlength',
+ 'operator' => '!=',
+ 'value' => '',
+ ),
+ ),
+ )
+ );
+
+ // text to show when characters are remaining
+ acf_render_field_setting(
+ $field,
+ array(
+ 'label' => __( 'Remaining Characters Text', 'frontend-admin' ),
+ 'instructions' => __( 'Text to show before the remaining character count. Use {count_down} or {count_up} as a placeholder for the number and {total} for the total', 'frontend-admin' ),
+ 'type' => 'text',
+ 'name' => 'remaining_characters_text',
+ 'default_value' => __( '{count_down} characters remaining. ({count_up} of {total})', 'frontend-admin' ),
+ 'conditions' => array(
+ array(
+ 'field' => 'show_remaining_characters',
+ 'operator' => '==',
+ 'value' => 1,
+ ),
+ array(
+ 'field' => 'maxlength',
+ 'operator' => '!=',
+ 'value' => '',
+ ),
+ ),
+ )
+ );
+ }
+
+ /**
+ * Injected into ACF native text/textarea settings (which already have maxlength).
+ * Adds only the Show Remaining Characters toggle and text after the existing maxlength setting.
+ */
+ public static function inject_show_remaining_setting( $field ) {
+ self::render_remaining_characters_fields( $field );
+ }
+
+ /**
+ * Injected into ACF native email/url settings (which have no maxlength).
+ * Adds both a Character Limit number field and the Show Remaining Characters toggle.
+ */
+ public static function inject_char_limit_and_remaining( $field ) {
+ acf_render_field_setting( $field, array(
+ 'label' => __( 'Character Limit', 'frontend-admin' ),
+ 'instructions' => __( 'Leave blank for no limit', 'frontend-admin' ),
+ 'type' => 'number',
+ 'name' => 'maxlength',
+ ) );
+ self::render_remaining_characters_fields( $field );
+ }
+
+ /**
+ * Renders the Show Remaining Characters toggle and Remaining Characters Text setting.
+ * Static so it can be called from static hook callbacks without an instance.
+ */
+ public static function render_remaining_characters_fields( $field ) {
+ acf_render_field_setting(
+ $field,
+ array(
+ 'label' => __( 'Show Remaining Characters', 'frontend-admin' ),
+ 'instructions' => __( 'Display the number of characters remaining based on the maxlength setting', 'frontend-admin' ),
+ 'type' => 'true_false',
+ 'name' => 'show_remaining_characters',
+ 'ui' => 1,
+ 'conditions' => array(
+ array(
+ 'field' => 'maxlength',
+ 'operator' => '!=',
+ 'value' => '',
+ ),
+ ),
+ )
+ );
+ acf_render_field_setting(
+ $field,
+ array(
+ 'label' => __( 'Remaining Characters Text', 'frontend-admin' ),
+ 'instructions' => __( 'Use {count_down} or {count_up} as a placeholder for the number and {total} for the total', 'frontend-admin' ),
+ 'type' => 'text',
+ 'name' => 'remaining_characters_text',
+ 'default_value' => __( '{count_down} characters remaining. ({count_up} of {total})', 'frontend-admin' ),
+ 'conditions' => array(
+ array(
+ 'field' => 'show_remaining_characters',
+ 'operator' => '==',
+ 'value' => 1,
+ ),
+ array(
+ 'field' => 'maxlength',
+ 'operator' => '!=',
+ 'value' => '',
+ ),
+ ),
+ )
+ );
+ }
+
+ /**
+ * Server-side maxlength enforcement for ACF native types that don't validate it themselves
+ * (email, url). Fires via acf/validate_value/type=X filters.
+ */
+ public static function validate_char_limit( $valid, $value, $field, $input ) {
+ if ( $valid && ! empty( $field['maxlength'] ) && is_string( $value ) && acf_strlen( $value ) > (int) $field['maxlength'] ) {
+ return sprintf( __( 'Value must not exceed %d characters', 'frontend-admin' ), $field['maxlength'] );
+ }
+ return $valid;
+ }
+
/**
* Apply basic formatting to prepare the value for default REST output.
*
--- a/acf-frontend-form-element/main/frontend/fields/general/class-related-terms.php
+++ b/acf-frontend-form-element/main/frontend/fields/general/class-related-terms.php
@@ -1039,7 +1039,25 @@
}
// vars
- $taxonomy_obj = get_taxonomy( $args['taxonomy'] );
+ $taxonomy_obj = get_taxonomy( $args['taxonomy'] );
+
+ if ( ! $taxonomy_obj ) {
+ wp_send_json_error(
+ array(
+ 'error' => __( 'Invalid taxonomy', 'frontend-admin' ),
+ )
+ );
+ }
+
+ // verify the current user is allowed to create terms in this taxonomy
+ if ( ! current_user_can( $taxonomy_obj->cap->edit_terms ) ) {
+ wp_send_json_error(
+ array(
+ 'error' => __( 'You do not have permission to add this term', 'frontend-admin' ),
+ )
+ );
+ }
+
$taxonomy_label = $taxonomy_obj->labels->singular_name;
// save?
--- a/acf-frontend-form-element/main/frontend/fields/general/class-text-editor.php
+++ b/acf-frontend-form-element/main/frontend/fields/general/class-text-editor.php
@@ -27,11 +27,14 @@
$this->category = 'content';
$this->public = false;
$this->defaults = array(
- 'tabs' => 'all',
- 'toolbar' => 'full',
- 'media_upload' => 1,
- 'default_value' => '',
- 'delay' => 0,
+ 'tabs' => 'all',
+ 'toolbar' => 'full',
+ 'media_upload' => 1,
+ 'default_value' => '',
+ 'delay' => 0,
+ 'maxlength' => '',
+ 'show_remaining_characters' => 0,
+ 'remaining_characters_text' => '',
);
@@ -145,6 +148,19 @@
)
);
+ // maxlength
+ acf_render_field_setting(
+ $field,
+ array(
+ 'label' => __( 'Character Limit', 'frontend-admin' ),
+ 'instructions' => __( 'Leave blank for no limit', 'frontend-admin' ),
+ 'type' => 'number',
+ 'name' => 'maxlength',
+ )
+ );
+
+ $this->remaining_characters_setting( $field );
+
}
@@ -173,6 +189,26 @@
return str_replace( ']]>', ']]>', $value );
}
+ /**
+ * validate_value
+ *
+ * Validates a field's value. Mirrors the client-side limit enforced in the
+ * TinyMCE editor, counting visible (non-HTML) characters.
+ *
+ * @param (bool|string) Whether the value is vaid or not.
+ * @param mixed $value The field value.
+ * @param array $field The field array.
+ * @param string $input The HTML input name.
+ * @return (bool|string)
+ */
+ function validate_value( $valid, $value, $field, $input ) {
+ if ( ! empty( $field['maxlength'] ) && is_string( $value ) && acf_strlen( wp_strip_all_tags( $value ) ) > $field['maxlength'] ) {
+ return sprintf( __( 'Value must not exceed %d characters', 'frontend-admin' ), $field['maxlength'] );
+ }
+
+ return $valid;
+ }
+
}
--- a/acf-frontend-form-element/main/frontend/fields/general/class-text.php
+++ b/acf-frontend-form-element/main/frontend/fields/general/class-text.php
@@ -24,11 +24,13 @@
$this->label = __( 'Text', 'frontend-admin' );
$this->public = false;
$this->defaults = array(
- 'default_value' => '',
- 'maxlength' => '',
- 'placeholder' => '',
- 'prepend' => '',
- 'append' => '',
+ 'default_value' => '',
+ 'maxlength' => '',
+ 'placeholder' => '',
+ 'prepend' => '',
+ 'append' => '',
+ 'show_remaining_characters' => 0,
+ 'remaining_characters_text' => '',
);
}
@@ -301,6 +303,8 @@
)
);
+ $this->remaining_characters_setting( $field );
+
}
/**
--- a/acf-frontend-form-element/main/frontend/forms/actions/term.php
+++ b/acf-frontend-form-element/main/frontend/forms/actions/term.php
@@ -431,8 +431,25 @@
return $form;
}
+ public function conditions_logic( $settings, $condition, $user ) {
+ $term_id = $settings['term_id'] ?? 'none';
+
+ if ( ! is_numeric( $term_id ) ) {
+ return $settings;
+ }
+
+ if ( ! current_user_can( 'edit_term', $term_id ) ) {
+ if ( ! in_array( 'edit_terms', $condition['special_permissions'] ) ) {
+ $settings['term_id'] = 'none';
+ }
+ }
+
+ return $settings;
+ }
+
public function __construct() {
add_filter( 'acf_frontend/save_form', array( $this, 'save_form' ), 4 );
+ add_filter( 'frontend_admin/special_permissions', array( $this, 'conditions_logic' ), 10, 3 );
}
}
fea_instance()->local_actions['term'] = new ActionTerm();
--- a/acf-frontend-form-element/main/frontend/forms/classes/display.php
+++ b/acf-frontend-form-element/main/frontend/forms/classes/display.php
@@ -1788,7 +1788,12 @@
}
//wrapper tag
- $field['wrapper_tag'] = $atts['tag'] ?? 'div';
+ $allowed_wrapper_tags = array( 'div', 'span', 'p', 'section', 'article', 'header', 'footer', 'aside', 'li', 'ul' );
+ $wrapper_tag = $atts['tag'] ?? 'div';
+ if ( ! in_array( $wrapper_tag, $allowed_wrapper_tags, true ) ) {
+ $wrapper_tag = 'div';
+ }
+ $field['wrapper_tag'] = $wrapper_tag;
echo fea_instance()->dynamic_values->render_field_display( $field, $source );
--- a/acf-frontend-form-element/main/frontend/forms/classes/permissions.php
+++ b/acf-frontend-form-element/main/frontend/forms/classes/permissions.php
@@ -34,7 +34,7 @@
global $post, $fea_limit_visibility, $fea_block_visibility;
- if( 'gutenberg' == $settings['builder'] ) {
+ if( ! empty( $settings['builder'] ) && 'gutenberg' == $settings['builder'] ) {
if( empty( $fea_block_visibility ) ) {
$settings['display'] = true;
return $settings;
@@ -213,9 +213,9 @@
if ( $submits - (int) $submitted <= 0 ) {
$settings['display'] = false;
if ( $condition['limit_reached'] == 'show_message' ) {
- echo '<div class="acf-notice -limit frontend-admin-limit-message"><p>' . $condition['limit_reached_message'] . '</p></div>';
+ $settings['message'] = '<div class="acf-notice -limit frontend-admin-limit-message"><p>' . $condition['limit_reached_message'] . '</p></div>';
} elseif ( $condition['limit_reached'] == 'custom_content' ) {
- echo wp_kses_post( $condition['limit_reached_content'] );
+ $settings['message'] = wp_kses_post( $condition['limit_reached_content'] );
}
}
}
@@ -236,16 +236,19 @@
$settings = apply_filters( 'frontend_admin/special_permissions', $settings, $condition, $active_user );
if ( $condition['not_allowed'] == 'show_message' ) {
- echo '<div class="acf-notice -limit frontend-admin-limit-message"><p>' . esc_html( $condition['not_allowed_message'] ) . '</p></div>';
+ $settings['message'] = '<div class="acf-notice -limit frontend-admin-limit-message"><p>' . esc_html( $condition['not_allowed_message'] ) . '</p></div>';
} elseif ( $condition['not_allowed'] == 'custom_content' ) {
- echo wp_kses_post( $condition['not_allowed_content'] );
+ $settings['message'] = wp_kses_post( $condition['not_allowed_content'] );
}
if ( $settings['display'] ) {
+ $settings['special_permissions'] = $condition['special_permissions'];
break;
}
}
+
if ( empty( $settings['display'] ) ) {
+ echo $settings['message'];
$settings = false;
}
--- a/acf-frontend-form-element/main/frontend/forms/classes/shortcodes.php
+++ b/acf-frontend-form-element/main/frontend/forms/classes/shortcodes.php
@@ -814,6 +814,10 @@
$wrapper = apply_filters( 'acf/field_wrapper_attributes', $wrapper, $field );
$tag = $field['wrapper_tag'] ?? 'div';
+ $tag = tag_escape( $tag );
+ if ( empty( $tag ) ) {
+ $tag = 'div';
+ }
?>
<<?php echo $tag . ' ' . acf_esc_attrs( $wrapper ) ?>>
<?php
--- a/acf-frontend-form-element/main/plugin.php
+++ b/acf-frontend-form-element/main/plugin.php
@@ -103,7 +103,7 @@
define( 'FEA_URL', $data['plugin_url'] );
define( 'FEA_DIR', $data['plugin_dir'] );
define( 'FEA_PLUGIN', $data['plugin'] );
- define( 'FEA_VERSION', '3.29.5' );
+ define( 'FEA_VERSION', '3.29.8' );
do_action( 'front_end_admin_loaded' );
// Add tutorial videos to plugin item on plugins page