Below is a differential between the unpatched vulnerable code and the patched update, for reference.
--- a/ultimate-member/includes/admin/class-enqueue.php
+++ b/ultimate-member/includes/admin/class-enqueue.php
@@ -204,6 +204,7 @@
wp_register_style( 'um_account', $css_url . 'um-account' . $suffix . '.css', array(), UM_VERSION );
wp_register_style( 'um_default_css', $css_url . 'um-old-default' . $suffix . '.css', array(), UM_VERSION );
wp_register_style( 'um_misc', $css_url . 'um-misc' . $suffix . '.css', array( 'um_styles' ), UM_VERSION );
+ wp_register_style( 'um_modal', $css_url . 'um-modal' . $suffix . '.css', array(), UM_VERSION );
wp_register_style( 'um_datetime', $libs_url . 'pickadate/default' . $suffix . '.css', array(), '3.6.2' );
wp_register_style( 'um_datetime_date', $libs_url . 'pickadate/default.date' . $suffix . '.css', array( 'um_datetime' ), '3.6.2' );
@@ -216,6 +217,7 @@
wp_enqueue_style( 'um_responsive' );
wp_enqueue_style( 'um_account' );
wp_enqueue_style( 'um_misc' );
+ wp_enqueue_style( 'um_modal' );
wp_enqueue_style( 'um_datetime_date' );
wp_enqueue_style( 'um_datetime_time' );
--- a/ultimate-member/includes/admin/core/class-admin-forms.php
+++ b/ultimate-member/includes/admin/core/class-admin-forms.php
@@ -442,6 +442,80 @@
/**
+ * Render API key field.
+ *
+ * A masked/secret field with a show/hide toggle. The real value is stored in a hidden input
+ * (submitted as um_options[<id>], exactly like a `text` field); a single visible, read-only
+ * display input shows either the partially-masked value (first/last characters kept, middle
+ * bulleted) or, once the eye button is toggled, the full editable value. Because only one
+ * input is ever visible, the field can never look duplicated even if the stylesheet is stale.
+ *
+ * Extra field config keys: `reveal_prefix` (int, default 6), `reveal_suffix` (int, default 4).
+ *
+ * @param array $field_data
+ *
+ * @return bool|string
+ */
+ function render_api_key( $field_data ) {
+
+ if ( empty( $field_data['id'] ) ) {
+ return false;
+ }
+
+ $id = ( ! empty( $this->form_data['prefix_id'] ) ? $this->form_data['prefix_id'] : '' ) . '_' . $field_data['id'];
+ $id_attr = ' id="' . esc_attr( $id ) . '" ';
+ $mask_id_attr = ' id="' . esc_attr( $id ) . '_masked" ';
+
+ $size_class = ! empty( $field_data['size'] ) ? 'um-' . $field_data['size'] . '-field' : 'um-long-field';
+
+ $data = array(
+ 'field_id' => $field_data['id'],
+ );
+
+ if ( ! empty( $field_data['attr'] ) && is_array( $field_data['attr'] ) ) {
+ $data = array_merge( $data, $field_data['attr'] );
+ }
+
+ $data_attr = '';
+ foreach ( $data as $key => $value ) {
+ $data_attr .= ' data-' . $key . '="' . esc_attr( $value ) . '" ';
+ }
+
+ $placeholder_attr = ! empty( $field_data['placeholder'] ) ? ' placeholder="' . esc_attr( $field_data['placeholder'] ) . '"' : '';
+
+ $name = $field_data['id'];
+ $name = ! empty( $this->form_data['prefix_id'] ) ? $this->form_data['prefix_id'] . '[' . $name . ']' : $name;
+ $name_attr = ' name="' . $name . '" ';
+
+ $value = $this->get_field_value( $field_data );
+ $value_attr = ' value="' . esc_attr( $value ) . '" ';
+
+ $readonly = '';
+ $title = '';
+ if ( ! empty( $value ) ) {
+ $title = ' title="' . esc_attr__( 'You can change the value only in the visible mode.', 'ultimate-member' ) . '" ';
+ $readonly = ' readonly ';
+ }
+
+ $prefix = isset( $field_data['reveal_prefix'] ) ? absint( $field_data['reveal_prefix'] ) : 6;
+ $suffix = isset( $field_data['reveal_suffix'] ) ? absint( $field_data['reveal_suffix'] ) : 4;
+
+ $show_label = esc_attr__( 'Show key', 'ultimate-member' );
+
+ // Inline layout so the input + toggle stay on one line even if the stylesheet is cached/stale.
+ $html = '<span class="um-api-key-field" style="display:flex;align-items:center;gap:6px;max-width:100%" data-reveal-prefix="' . esc_attr( $prefix ) . '" data-reveal-suffix="' . esc_attr( $suffix ) . '">';
+ // Real value carrier — the only element submitted as um_options[<id>]. Never shown.
+ $html .= "<input type="hidden" $id_attr $name_attr $data_attr $value_attr class="um-forms-field um-api-key-value" />";
+ // Single visible display input (no name → not submitted). JS fills/masks it and toggles readonly.
+ $html .= "<input type="text" $mask_id_attr $data_attr class="um-api-key-display " . esc_attr( $size_class ) . "" autocomplete="off" spellcheck="false"" . $placeholder_attr . $readonly . $title . ' />';
+ // Show/hide toggle.
+ $html .= '<button type="button" class="button um-api-key-toggle" aria-label="' . $show_label . '" title="' . $show_label . '"><span class="dashicons dashicons-visibility"></span></button>';
+ $html .= '</span>';
+
+ return $html;
+ }
+
+ /**
* Render text field
*
* @param $field_data
--- a/ultimate-member/includes/admin/core/class-admin-settings.php
+++ b/ultimate-member/includes/admin/core/class-admin-settings.php
@@ -2252,7 +2252,7 @@
'fields' => array(
array(
'id' => 'um_google_maps_js_api_key',
- 'type' => 'text',
+ 'type' => 'api_key',
'label' => __( 'Maps JavaScript API Key', 'ultimate-member' ),
'size' => 'medium',
),
--- a/ultimate-member/includes/blocks/um-account/src/index.asset.php
+++ b/ultimate-member/includes/blocks/um-account/src/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react-jsx-runtime', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-server-side-render'), 'version' => '576298ed33907f5109e7');
+<?php return array('dependencies' => array('react-jsx-runtime', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-element', 'wp-server-side-render'), 'version' => 'fa4c7b2c8b0f92d09445');
--- a/ultimate-member/includes/blocks/um-forms/src/index.asset.php
+++ b/ultimate-member/includes/blocks/um-forms/src/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react-jsx-runtime', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-element', 'wp-server-side-render'), 'version' => 'a76ebbc5f9f396f304af');
+<?php return array('dependencies' => array('react-jsx-runtime', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-element', 'wp-server-side-render'), 'version' => 'e54f2cf8ff96222279ad');
--- a/ultimate-member/includes/blocks/um-member-directories/src/index.asset.php
+++ b/ultimate-member/includes/blocks/um-member-directories/src/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react-jsx-runtime', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-element', 'wp-server-side-render'), 'version' => '04ada072859cfd5901eb');
+<?php return array('dependencies' => array('react-jsx-runtime', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-data', 'wp-element', 'wp-server-side-render'), 'version' => '9d8371d21dfab8b5f072');
--- a/ultimate-member/includes/blocks/um-password-reset/src/index.asset.php
+++ b/ultimate-member/includes/blocks/um-password-reset/src/index.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array('react-jsx-runtime', 'wp-block-editor', 'wp-blocks', 'wp-server-side-render'), 'version' => 'd1e8ad89d47a20d3414b');
+<?php return array('dependencies' => array('react-jsx-runtime', 'wp-block-editor', 'wp-blocks', 'wp-server-side-render'), 'version' => 'ae925d1418549dd8db29');
--- a/ultimate-member/includes/core/class-builtin.php
+++ b/ultimate-member/includes/core/class-builtin.php
@@ -747,17 +747,16 @@
$this->core_fields = apply_filters( 'um_core_fields_hook', $this->core_fields );
}
-
/**
* Predefined Fields
*/
- function set_predefined_fields() {
+ public function set_predefined_fields() {
global $wp_roles;
$um_roles = array();
if ( ! empty( $wp_roles->roles ) ) {
$exclude_roles = array_diff( array_keys( $wp_roles->roles ), UM()->roles()->get_editable_user_roles() );
- $um_roles = UM()->roles()->get_roles( false, $exclude_roles );
+ $um_roles = UM()->roles()->get_roles( false, $exclude_roles );
}
/**
--- a/ultimate-member/includes/core/class-fields.php
+++ b/ultimate-member/includes/core/class-fields.php
@@ -4081,9 +4081,12 @@
if ( ! empty( $options ) ) {
- $roles = array_map( function( $item ) {
- return html_entity_decode( $item, ENT_QUOTES );
- }, $roles );
+ $roles = array_map(
+ function ( $item ) {
+ return html_entity_decode( $item, ENT_QUOTES );
+ },
+ $roles
+ );
//fix when customers change options for role (radio/dropdown) fields
$intersected_options = array();
@@ -4601,12 +4604,10 @@
if ( isset( $data['label'] ) || ! empty( $data['icon'] ) ) {
$output .= $this->field_label( $data['label'], $key, $data );
}
- $response = wp_oembed_get( $_field_value );
- if ( empty( $response ) ) {
- $response = $_field_value;
- }
+
$output .= '<div class="um-field-area">';
- $output .= '<div class="um-field-value">' . $response . '</div>';
+ $output .= '<div class="um-field-value">' . $_field_value . '</div>'; // `$_field_value` variable can contain HTML code after filtered via the `um_profile_field_filter_hook__oembed()` function.
+ $output .= '</div>';
$output .= '</div>';
break;
/* HTML */
--- a/ultimate-member/includes/core/class-form.php
+++ b/ultimate-member/includes/core/class-form.php
@@ -1107,7 +1107,7 @@
$roles = UM()->roles()->get_roles( false, $exclude_roles );
$roles = array_map(
- function( $item ) {
+ function ( $item ) {
return html_entity_decode( $item, ENT_QUOTES );
},
$roles
--- a/ultimate-member/includes/core/class-roles-capabilities.php
+++ b/ultimate-member/includes/core/class-roles-capabilities.php
@@ -444,50 +444,60 @@
return array_shift( $roles_in_priority );
}
-
/**
* Get editable UM user roles
*
* @return array
*/
- function get_editable_user_roles() {
+ public function get_editable_user_roles() {
$editable_roles = array( 'subscriber' );
// User has roles so look for a UM Role one
$um_roles_keys = get_option( 'um_roles', array() );
if ( ! empty( $um_roles_keys ) && is_array( $um_roles_keys ) ) {
- $um_roles_keys = array_map( function( $item ) {
- return 'um_' . $item;
- }, $um_roles_keys );
+ $um_roles_keys = array_map(
+ static function ( $item ) {
+ return 'um_' . $item;
+ },
+ $um_roles_keys
+ );
$editable_roles = array_merge( $editable_roles, $um_roles_keys );
}
+ $banned_admin_capabilities = UM()->common()->secure()->get_banned_capabilities_list();
+ foreach ( $editable_roles as $k => $editable_role_slug ) {
+ $editable_role = get_role( $editable_role_slug );
+ if ( null !== $editable_role ) {
+ foreach ( $banned_admin_capabilities as $cap_key ) {
+ if ( $editable_role->has_cap( $cap_key ) ) {
+ unset( $editable_roles[ $k ] );
+ break;
+ }
+ }
+ }
+ }
+
/**
- * UM hook
+ * Filters Ultimate Member editable roles list.
+ *
+ * @since 2.0.0
+ * @hook um_extend_editable_roles
*
- * @type filter
- * @title um_extend_editable_roles
- * @description Extend Editable User Roles
- * @input_vars
- * [{"var":"$editable_roles","type":"array","desc":"Editable Roles Keys"}]
- * @change_log
- * ["Since: 2.6.0"]
- * @usage add_filter( 'um_extend_editable_roles', 'function_name', 10, 1 );
- * @example
- * <?php
- * add_filter( 'um_extend_editable_roles', 'my_um_extend_editable_roles', 10, 1 );
- * function my_um_extend_editable_roles( $editable_roles ) {
- * // your code here
+ * @param {array} $editable_roles Ultimate Member editable roles list.
+ *
+ * @return {array} Ultimate Member editable roles list.
+ *
+ * @example <caption>Change Ultimate Member editable roles.</caption>
+ * function custom_um_extend_editable_roles( $editable_roles ) {
+ * $editable_roles[] = 'editor';
* return $editable_roles;
* }
- * ?>
+ * add_filter( 'um_extend_editable_roles', 'custom_um_extend_editable_roles' );
*/
- $editable_roles = apply_filters( 'um_extend_editable_roles', $editable_roles );
- return $editable_roles;
+ return apply_filters( 'um_extend_editable_roles', array_values( $editable_roles ) );
}
-
/**
* @param $user_id
*
--- a/ultimate-member/includes/core/um-filters-fields.php
+++ b/ultimate-member/includes/core/um-filters-fields.php
@@ -15,18 +15,36 @@
if ( empty( $value ) ) {
return '';
}
- $responce = wp_oembed_get( $value );
- if ( empty( $responce ) ) {
- $value = '<a href="' . esc_url( $value ) . '" target="_blank">' . esc_html( $value ) . '</a>';
+ $response = wp_oembed_get( $value );
+ if ( ! empty( $response ) ) {
+ // External resource from a supported oEmbed provider.
+ $value = $response;
+ } elseif ( 0 === strpos( $value, home_url() ) ) {
+ // local resource.
+ $attachment_id = attachment_url_to_postid( $value );
+ if ( $attachment_id ) {
+ // Local resource from the Media Library then using WordPress native function to display them.
+ $mime = get_post_mime_type( $attachment_id );
+ if ( 0 === strpos( $mime, 'image/' ) ) {
+ $value = wp_get_attachment_image( $attachment_id, 'full' );
+ } elseif ( 0 === strpos( $mime, 'audio/' ) ) {
+ $value = apply_shortcodes( '[audio src="' . esc_url( $value ) . '"]' );
+ } elseif ( 0 === strpos( $mime, 'video/' ) ) {
+ $value = apply_shortcodes( '[video src="' . esc_url( $value ) . '"]' );
+ }
+ } else {
+ // Local resource from the third-party plugin that is not supported by WordPress Media Library.
+ $value = '<iframe src="' . esc_url( $value ) . '" title="' . esc_attr( $data['label'] ) . '" width="800" height="450"></iframe>';
+ }
} else {
- $value = $responce;
+ // Other URL wrapped to the <a> tag.
+ $value = '<a href="' . esc_url( $value ) . '" target="_blank">' . esc_html( $value ) . '</a>';
}
return $value;
}
add_filter( 'um_profile_field_filter_hook__oembed', 'um_profile_field_filter_hook__oembed', 99, 2 );
-
/**
* Outputs a SoundCloud track
*
--- a/ultimate-member/includes/um-short-functions.php
+++ b/ultimate-member/includes/um-short-functions.php
@@ -205,7 +205,7 @@
$regex = '~{(usermeta:[^}]*)}~';
preg_match_all( $regex, $content, $matches );
- $keys_blacklist = array( 'password_reset_link' );
+ $keys_blacklist = array( 'password_reset_link', 'account_secret_hash', 'account_secret_hash_expiry', 'account_activation_link' );
$keys_blacklist = array_merge( $keys_blacklist, UM()->builtin()->blacklist_fields );
/**
* Filters Ultimate Member usermeta keys to avoid displaying sensitive information via {usermeta:{meta_key}} placeholder.
--- a/ultimate-member/ultimate-member.php
+++ b/ultimate-member/ultimate-member.php
@@ -3,7 +3,7 @@
* Plugin Name: Ultimate Member
* Plugin URI: http://ultimatemember.com/
* Description: The easiest way to create powerful online communities and beautiful user profiles with WordPress
- * Version: 2.12.0
+ * Version: 2.12.1
* Author: Ultimate Member
* Author URI: http://ultimatemember.com/
* License: GPLv3
@@ -35,8 +35,8 @@
define( 'UM_VERSION', $plugin_data['Version'] );
define( 'UM_PLUGIN_NAME', $plugin_data['Name'] );
define( 'UM_WP_FUNCTIONS_VERSION', '6.9.0' ); // Updates every major WordPress release.
-define( 'UM_LICENSE_REQUEST_DEBUG', false ); // Set true then need to debug the license request.
-define( 'UM_UPDATER_DEBUG', false ); // Set true then need to debug the upgrade packages.
+define( 'UM_LICENSE_REQUEST_DEBUG', false ); // Set true, then need to debug the license request.
+define( 'UM_UPDATER_DEBUG', false ); // Set true, then need to debug the upgrade packages.
// define( 'UM_DEV_MODE', true );
require_once 'includes/class-functions.php';