--- a/mediapress/core/shortcodes/mpp-shortcode-gallery-list.php
+++ b/mediapress/core/shortcodes/mpp-shortcode-gallery-list.php
@@ -98,12 +98,12 @@
unset( $atts['meta_value'] );
}
// These variables are used in the template.
- $shortcode_column = $atts['column'];
- $show_pagination = $atts['show_pagination'];
+ $shortcode_column = absint( $atts['column'] );
+ $show_pagination = absint( $atts['show_pagination'] );
- $show_creator = $atts['show_creator'];
- $before_creator = $atts['before_creator'];
- $after_creator = $atts['after_creator'];
+ $show_creator = absint( $atts['show_creator'] );
+ $before_creator = $atts['before_creator'] ? wp_kses_data( $atts['before_creator'] ) : '';
+ $after_creator = $atts['after_creator'] ? wp_kses_data( $atts['after_creator'] ) : '';
unset( $atts['column'] );
// unset( $atts['view'] );
@@ -112,6 +112,7 @@
unset( $atts['for'] );
if ( ! empty( $for ) ) {
+ $for = sanitize_key( $for );
$atts['user_id'] = mpp_get_dynamic_user_id_for_context( $for );
if ( empty( $atts['user_id'] ) ) {
return ''; // shortcircuit.
@@ -199,9 +200,9 @@
$gallery_id = absint( $atts['id'] );
- $show_creator = $atts['show_creator'];
- $before_creator = $atts['before_creator'];
- $after_creator = $atts['after_creator'];
+ $show_creator = absint( $atts['show_creator'] );
+ $before_creator = wp_kses_data( $atts['before_creator'] );
+ $after_creator = wp_kses_data( $atts['after_creator'] );
global $wpdb;
@@ -223,21 +224,21 @@
unset( $atts['meta_value'] );
}
- $view = $atts['view'];
+ $view = sanitize_key( $atts['view'] );
unset( $atts['id'] );
unset( $atts['view'] );
$atts['gallery_id'] = $gallery_id;
$atts['status'] = mpp_get_accessible_statuses( $gallery->component, $gallery->component_id );
- $shortcode_column = $atts['column'];
+ $shortcode_column = absint( $atts['column'] );
mpp_shortcode_save_media_data( 'column', $shortcode_column );
mpp_shortcode_save_media_data( 'shortcode_args', $atts );
unset( $atts['column'] );
- $show_pagination = $atts['show_pagination'];
+ $show_pagination = absint( $atts['show_pagination'] );
unset( $atts['show_pagination'] );
$atts = array_filter( $atts );
--- a/mediapress/mediapress.php
+++ b/mediapress/mediapress.php
@@ -1,7 +1,7 @@
<?php
/**
* Plugin Name: MediaPress
- * Version: 1.6.2
+ * Version: 1.6.3
* Author: BuddyDev
* Plugin URI: https://buddydev.com/mediapress/
* Author URI: https://buddydev.com
--- a/mediapress/templates/mediapress/default/buddypress/directory/index.php
+++ b/mediapress/templates/mediapress/default/buddypress/directory/index.php
@@ -21,7 +21,7 @@
<div class="item-list-tabs" role="navigation">
<ul>
<li class="selected" id="mpp-all">
- <a href="<?php echo get_permalink( buddypress()->pages->mediapress->id ); ?>"><?php printf( __( 'All Galleries <span>%s</span>', 'mediapress' ), mpp_get_total_gallery_count() ) ?></a>
+ <a href="<?php echo esc_url( get_permalink( buddypress()->pages->mediapress->id ) ); ?>"><?php printf( __( 'All Galleries <span>%s</span>', 'mediapress' ), mpp_get_total_gallery_count() ) ?></a>
</li>
<?php do_action( 'mpp_directory_types' ) ?>
@@ -35,7 +35,7 @@
<?php $active_types = mpp_get_active_types(); ?>
<?php foreach( $active_types as $type => $type_object ):?>
- <option value="<?php echo $type;?>"><?php echo $type_object->get_label();?> </option>
+ <option value="<?php echo esc_attr( $type );?>"><?php echo $type_object->get_label();?> </option>
<?php endforeach;?>
<?php do_action( 'mpp_gallery_directory_order_options' ) ?>
--- a/mediapress/templates/mediapress/default/buddypress/groups/gallery/single.php
+++ b/mediapress/templates/mediapress/default/buddypress/groups/gallery/single.php
@@ -28,7 +28,7 @@
<?php
$gallery = mpp_get_current_gallery();
-$type = $gallery->type;
+$type = esc_attr( $gallery->type );
?>
<?php if ( mpp_have_media() ) : ?>
--- a/mediapress/templates/mediapress/default/buddypress/members/gallery/single.php
+++ b/mediapress/templates/mediapress/default/buddypress/members/gallery/single.php
@@ -28,7 +28,7 @@
<?php
$gallery = mpp_get_current_gallery();
-$type = $gallery->type;
+$type = esc_attr( $gallery->type );
?>
<?php if ( mpp_have_media() ) : ?>
--- a/mediapress/templates/mediapress/default/gallery/create.php
+++ b/mediapress/templates/mediapress/default/gallery/create.php
@@ -15,19 +15,19 @@
$status = mpp_get_default_status();
if ( ! empty( $_POST['mpp-gallery-title'] ) ) {
- $title = $_POST['mpp-gallery-title'];
+ $title = wp_unslash( $_POST['mpp-gallery-title'] );
}
if ( ! empty( $_POST['mpp-gallery-description'] ) ) {
- $description = $_POST['mpp-gallery-description'];
+ $description = wp_unslash( $_POST['mpp-gallery-description'] );
}
if ( ! empty( $_POST['mpp-gallery-status'] ) ) {
- $status = $_POST['mpp-gallery-status'];
+ $status = wp_unslash( $_POST['mpp-gallery-status'] );
}
if ( ! empty( $_POST['mpp-gallery-type'] ) ) {
- $type = $_POST['mpp-gallery-type'];
+ $type = wp_unslash( $_POST['mpp-gallery-type'] );
}
?>
--- a/mediapress/templates/mediapress/default/gallery/loop-gallery.php
+++ b/mediapress/templates/mediapress/default/gallery/loop-gallery.php
@@ -14,7 +14,7 @@
<div class='mpp-g mpp-item-list mpp-galleries-list'>
<?php while ( mpp_have_galleries() ) : mpp_the_gallery(); ?>
- <?php $type = mpp_get_gallery_type(); ?>
+ <?php $type = esc_attr( mpp_get_gallery_type() ); ?>
<div class="<?php mpp_gallery_class( mpp_get_gallery_grid_column_class() ); ?>" id="mpp-gallery-<?php mpp_gallery_id(); ?>" data-mpp-type="<?php echo $type;?>" >
<?php do_action( 'mpp_before_gallery_entry' ); ?>
--- a/mediapress/templates/mediapress/default/gallery/media/manage/edit.php
+++ b/mediapress/templates/mediapress/default/gallery/media/manage/edit.php
@@ -16,11 +16,11 @@
<div class="mpp-u-1-2 mpp-media-thumbnail mpp-cover-wrapper ">
<?php do_action( 'mpp_before_edit_media_thumbnail_field', $media->id ); ?>
- <div class="mpp-editable-cover mpp-media-editable-cover" id="mpp-cover-<?php echo $media->id; ?>">
+ <div class="mpp-editable-cover mpp-media-editable-cover" id="mpp-cover-<?php echo esc_attr( $media->id ); ?>">
<img src="<?php mpp_media_src( 'thumbnail' ); ?>"
class='mpp-image mpp-cover-image mpp-media-cover-image '/>
<input type="hidden" class="mpp-gallery-id" value="<?php echo mpp_get_current_gallery_id(); ?>"/>
- <input type="hidden" class="mpp-parent-id" value="<?php echo $media->id; ?>"/>
+ <input type="hidden" class="mpp-parent-id" value="<?php echo esc_attr( $media->id ); ?>"/>
<input type="hidden" class="mpp-parent-type" value="media"/>
</div>
--- a/mediapress/templates/mediapress/default/gallery/views/grid-audio.php
+++ b/mediapress/templates/mediapress/default/gallery/views/grid-audio.php
@@ -5,7 +5,7 @@
}
?>
<?php while ( mpp_have_media() ) : mpp_the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="<?php mpp_media_class( 'mpp-u-6-24' ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_item' ); ?>
--- a/mediapress/templates/mediapress/default/gallery/views/grid-doc.php
+++ b/mediapress/templates/mediapress/default/gallery/views/grid-doc.php
@@ -6,7 +6,7 @@
?>
<?php while ( mpp_have_media() ) : mpp_the_media(); ?>
<?php $media = mpp_get_media(); ?>
- <?php $type = mpp_get_media_type( $media ); ?>
+ <?php $type = esc_attr( mpp_get_media_type( $media ) ); ?>
<div class="mpp-u <?php mpp_media_class( mpp_get_media_grid_column_class() ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_item' ); ?>
@@ -26,7 +26,7 @@
$class = '';
}
?>
- <a href="<?php echo esc_attr( $url ); ?>" <?php mpp_media_html_attributes( array( 'class' => "mpp-item-thumbnail mpp-media-thumbnail mpp-photo-thumbnail {$class}" ) ); ?> data-mpp-type="<?php echo $type;?>">
+ <a href="<?php echo esc_url( $url ); ?>" <?php mpp_media_html_attributes( array( 'class' => "mpp-item-thumbnail mpp-media-thumbnail mpp-photo-thumbnail {$class}" ) ); ?> data-mpp-type="<?php echo $type;?>">
<img src="<?php mpp_media_src( 'thumbnail' ); ?>" alt="<?php echo esc_attr( mpp_get_media_title() ); ?> "/>
</a>
<a href="<?php echo esc_url( $url ); ?>" <?php mpp_media_html_attributes(
--- a/mediapress/templates/mediapress/default/gallery/views/grid-photo.php
+++ b/mediapress/templates/mediapress/default/gallery/views/grid-photo.php
@@ -5,7 +5,7 @@
}
?>
<?php while ( mpp_have_media() ) : mpp_the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="mpp-u <?php mpp_media_class( mpp_get_media_grid_column_class() ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_item' ); ?>
--- a/mediapress/templates/mediapress/default/gallery/views/grid-video.php
+++ b/mediapress/templates/mediapress/default/gallery/views/grid-video.php
@@ -5,7 +5,7 @@
}
?>
<?php while ( mpp_have_media() ): mpp_the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="<?php mpp_media_class( 'mpp-u-12-24' ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_item' ); ?>
--- a/mediapress/templates/mediapress/default/gallery/views/grid.php
+++ b/mediapress/templates/mediapress/default/gallery/views/grid.php
@@ -5,7 +5,7 @@
}
?>
<?php while ( mpp_have_media() ) : mpp_the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="mpp-u <?php mpp_media_class( mpp_get_media_grid_column_class() ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_item' ); ?>
--- a/mediapress/templates/mediapress/default/gallery/views/list.php
+++ b/mediapress/templates/mediapress/default/gallery/views/list.php
@@ -10,7 +10,7 @@
?>
<?php
$gallery = mpp_get_current_gallery();
-$type = $gallery->type;
+$type = esc_attr( $gallery->type );
?>
<ul class="mpp-u mpp-item-list mpp-list-item-<?php echo $type; ?>">
--- a/mediapress/templates/mediapress/default/shortcodes/gallery-list.php
+++ b/mediapress/templates/mediapress/default/shortcodes/gallery-list.php
@@ -25,7 +25,7 @@
<?php while ( $query->have_galleries() ) : $query->the_gallery(); ?>
<?php $type = mpp_get_gallery_type(); ?>
- <div class="<?php mpp_gallery_class( mpp_get_grid_column_class( $shortcode_column ) ); ?>" id="mpp-gallery-<?php mpp_gallery_id(); ?>" data-mpp-type="<?php echo $type;?>">
+ <div class="<?php mpp_gallery_class( mpp_get_grid_column_class( $shortcode_column ) ); ?>" id="mpp-gallery-<?php mpp_gallery_id(); ?>" data-mpp-type="<?php echo esc_attr( $type );?>">
<?php do_action( 'mpp_before_gallery_shortcode_entry' ); ?>
@@ -37,7 +37,7 @@
<a href="<?php mpp_gallery_permalink(); ?>" <?php mpp_gallery_html_attributes( array(
'class' => 'mpp-item-thumbnail mpp-gallery-cover',
'data-mpp-context' => 'shortcode',
- ) ); ?> data-mpp-type="<?php echo $type;?>">
+ ) ); ?> data-mpp-type="<?php echo esc_attr( $type );?>">
<img src="<?php mpp_gallery_cover_src( 'thumbnail' ); ?>" alt="<?php echo esc_attr( mpp_get_gallery_title() ); ?>"/>
</a>
@@ -49,7 +49,7 @@
'class' => 'mpp-item-title mpp-gallery-title',
'data-mpp-context' => 'shortcode',
) );
- ?> data-mpp-type="<?php echo $type;?>">
+ ?> data-mpp-type="<?php echo esc_attr( $type );?>">
<?php mpp_gallery_title(); ?>
</a>
--- a/mediapress/templates/mediapress/default/shortcodes/grid-audio.php
+++ b/mediapress/templates/mediapress/default/shortcodes/grid-audio.php
@@ -17,7 +17,7 @@
<div class="mpp-g mpp-item-list mpp-media-list mpp-shortcode-item-list mpp-shortcode-list-media mpp-shortcode-list-media-audio ">
<?php while ( $query->have_media() ) : $query->the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="<?php mpp_media_class( mpp_get_grid_column_class( mpp_shortcode_get_media_data( 'column' ) ) ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_shortcode_item' ); ?>
--- a/mediapress/templates/mediapress/default/shortcodes/grid-doc.php
+++ b/mediapress/templates/mediapress/default/shortcodes/grid-doc.php
@@ -22,7 +22,7 @@
<?php while ( $query->have_media() ) : $query->the_media(); ?>
<?php $media = mpp_get_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="mpp-u <?php mpp_media_class( mpp_get_grid_column_class( mpp_shortcode_get_media_data( 'column' ) ) ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_shortcode_item' ); ?>
--- a/mediapress/templates/mediapress/default/shortcodes/grid-photo.php
+++ b/mediapress/templates/mediapress/default/shortcodes/grid-photo.php
@@ -21,7 +21,7 @@
<div class="mpp-g mpp-item-list mpp-media-list mpp-shortcode-item-list mpp-shortcode-list-media mpp-shortcode-list-media-photo <?php echo $lightbox_class; ?> " data-media-ids="<?php echo $media_ids; ?>">
<?php while ( $query->have_media() ) : $query->the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="mpp-u <?php mpp_media_class( mpp_get_grid_column_class( mpp_shortcode_get_media_data( 'column' ) ) ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_shortcode_item' ); ?>
--- a/mediapress/templates/mediapress/default/shortcodes/grid-video.php
+++ b/mediapress/templates/mediapress/default/shortcodes/grid-video.php
@@ -17,7 +17,7 @@
<div class="mpp-g mpp-item-list mpp-media-list mpp-shortcode-item-list mpp-shortcode-list-media mpp-shortcode-list-media-video ">
<?php while ( $query->have_media() ) : $query->the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="<?php mpp_media_class( 'mpp-shortcode-item mpp-shortcode-video-item ' . mpp_get_grid_column_class( mpp_shortcode_get_media_data( 'column' ) ) ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_shortcode_item' ); ?>
--- a/mediapress/templates/mediapress/default/shortcodes/grid.php
+++ b/mediapress/templates/mediapress/default/shortcodes/grid.php
@@ -21,7 +21,7 @@
<div class="mpp-g mpp-item-list mpp-media-list mpp-shortcode-item-list mpp-shortcode-list-media mpp-shortcode-list-media-all <?php echo $lightbox_class; ?> " data-media-ids="<?php echo $media_ids; ?>">
<?php while ( $query->have_media() ) : $query->the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="mpp-u <?php mpp_media_class( mpp_get_grid_column_class( mpp_shortcode_get_media_data( 'column' ) ) ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_shortcode_item' ); ?>
--- a/mediapress/templates/mediapress/default/shortcodes/list.php
+++ b/mediapress/templates/mediapress/default/shortcodes/list.php
@@ -18,7 +18,7 @@
<ul class="mpp-item-list mpp-list-item-shortcode">
<?php while ( $query->have_media() ) : $query->the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<li class="mpp-list-item-entry mpp-list-item-entry-<?php mpp_media_type(); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_shortcode_item' ); ?>
--- a/mediapress/templates/mediapress/default/shortcodes/uploader.php
+++ b/mediapress/templates/mediapress/default/shortcodes/uploader.php
@@ -42,7 +42,7 @@
<!-- end of remote media -->
<?php endif;?>
- <input type='hidden' name='mpp-context' class="mpp-context" id='mpp-context' value="<?php echo $context; ?>"/>
+ <input type='hidden' name='mpp-context' class="mpp-context" id='mpp-context' value="<?php echo esc_attr( $context ); ?>"/>
<?php if ( $type ) : ?>
<input type='hidden' name='mpp-uploading-media-type' class='mpp-uploading-media-type' value="<?php echo esc_attr( $type ); ?>"/>
--- a/mediapress/templates/mediapress/default/sitewide/gallery/single.php
+++ b/mediapress/templates/mediapress/default/sitewide/gallery/single.php
@@ -28,7 +28,7 @@
<?php
$gallery = mpp_get_current_gallery();
-$type = $gallery->type;
+$type = esc_attr( $gallery->type );
?>
<?php if ( mpp_have_media() ) : ?>
--- a/mediapress/templates/mediapress/default/widgets/gallery-list.php
+++ b/mediapress/templates/mediapress/default/widgets/gallery-list.php
@@ -16,7 +16,7 @@
<div class='mpp-g mpp-item-list mpp-galleries-list'>
<?php while ( $query->have_galleries() ) : $query->the_gallery(); ?>
- <?php $type = mpp_get_gallery_type();?>
+ <?php $type = esc_attr( mpp_get_gallery_type() );?>
<div class="<?php mpp_gallery_class( 'mpp-u-1-1' ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_gallery_widget_entry' ); ?>
--- a/mediapress/templates/mediapress/default/widgets/grid-audio.php
+++ b/mediapress/templates/mediapress/default/widgets/grid-audio.php
@@ -16,7 +16,7 @@
<div class='mpp-g mpp-item-list mpp-media-list mpp-audio-list'>
<?php while ( $query->have_media() ) : $query->the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="<?php mpp_media_class( 'mpp-widget-item mpp-widget-audio-item ' . mpp_get_grid_column_class( 1 ) ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_widget_item' ); ?>
--- a/mediapress/templates/mediapress/default/widgets/grid-doc.php
+++ b/mediapress/templates/mediapress/default/widgets/grid-doc.php
@@ -17,7 +17,7 @@
<?php while ( $query->have_media() ) : $query->the_media(); ?>
<?php $media = mpp_get_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="<?php mpp_media_class( 'mpp-widget-item mpp-widget-media-item ' . mpp_get_grid_column_class( 1 ) ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_widget_item' ); ?>
--- a/mediapress/templates/mediapress/default/widgets/grid-photo.php
+++ b/mediapress/templates/mediapress/default/widgets/grid-photo.php
@@ -16,7 +16,7 @@
<div class='mpp-g mpp-item-list mpp-media-list mpp-photo-list'>
<?php while ( $query->have_media() ) : $query->the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="<?php mpp_media_class( 'mpp-widget-item mpp-widget-photo-item ' . mpp_get_grid_column_class( 1 ) ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_widget_item' ); ?>
--- a/mediapress/templates/mediapress/default/widgets/grid-video.php
+++ b/mediapress/templates/mediapress/default/widgets/grid-video.php
@@ -15,7 +15,7 @@
<div class='mpp-g mpp-item-list mpp-media-list mpp-video-list'>
<?php while ( $query->have_media() ) : $query->the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="<?php mpp_media_class( 'mpp-widget-item mpp-widget-video-item ' . mpp_get_grid_column_class( 1 ) ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_widget_item' ); ?>
--- a/mediapress/templates/mediapress/default/widgets/grid.php
+++ b/mediapress/templates/mediapress/default/widgets/grid.php
@@ -16,7 +16,7 @@
<div class='mpp-g mpp-item-list mpp-media-list mpp-video-list'>
<?php while ( $query->have_media() ) : $query->the_media(); ?>
- <?php $type = mpp_get_media_type(); ?>
+ <?php $type = esc_attr( mpp_get_media_type() ); ?>
<div class="<?php mpp_media_class( 'mpp-widget-item mpp-widget-media-item ' . mpp_get_grid_column_class( 1 ) ); ?>" data-mpp-type="<?php echo $type;?>">
<?php do_action( 'mpp_before_media_widget_item' ); ?>